-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try lld #5813
Try lld #5813
Conversation
76631c2
to
65b3e0d
Compare
.github/workflows/ci.yaml
Outdated
@@ -12,7 +12,7 @@ env: | |||
CARGO_NET_RETRY: 10 | |||
CI: 1 | |||
RUST_BACKTRACE: short | |||
RUSTFLAGS: -D warnings | |||
RUSTFLAGS: -D warnings -C linker=clang -C link-arg=-fuse-ld=lld |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to install lld first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kinda hoped that it is there by default, but no :(
My endg goal is to try lld on windows (as it is the CI bottleneck). I guess I can do this by seetting different RUSTFLAGS per OS, but I can't figure a convenient way to do that
328ade4
to
375a2b7
Compare
Ok, got to work it on windows, but, apparently, it is slower? :-( |
Hm, second try seems much faster, bors r+ |
Is that from the llvm-tools-preview component or whatever it's called? I actually thought those were stubs on windows. |
I have no idea, tbh |
Rust-lld is always installed, For using system LLD on windows-gnu you use |
For posterity, I don't think this significantly improved overall compile time for windous on CI for us, so either the difference in linking time is small, or linking time is small relative to the rest of compilation. Note, however, that we cache all the dependencies, so linking time should be relatively more important than in the case of from-scratch compilation. |
No description provided.