Add doc gen to the generate_enum_match_method
assist
#7570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a small extension to #7562, generating default comments. I wasn't sure if this would fit the goals of Rust-Analyzer, so I chose to split it into a separate PR. This is especially useful when writing code in a codebase which uses
#![warn(missing_docs)]
lint, as many production-grade libraries do.The comments we're generating here are similar to the ones found on
Option::is_some
andResult::is_err
. I briefly considered only generating these forpub
types, but they seem small and unobtrusive enough that they're probably useful in the general case. Thanks!Example
input
output
Future Directions
This opens up the path to adding an assist for generating these comments on existing
is_
methods. This would make it both easy to document new code, and update existing code with documentation.