Skip to content

Commit

Permalink
Auto merge of #8329 - Alexendoo:enum-variant-names, r=giraffate
Browse files Browse the repository at this point in the history
Don't suggest an empty variant name in `enum_variant_names`

changelog: false positive fix: [`enum_variant_names`]: No longer suggests an empty variant name

Fixes #8324
  • Loading branch information
bors committed Jan 21, 2022
2 parents 8bb4690 + 7c56317 commit f4709e6
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
3 changes: 3 additions & 0 deletions clippy_lints/src/enum_variants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ fn check_variant(cx: &LateContext<'_>, threshold: u64, def: &EnumDef<'_>, item_n
let name = var.ident.name.as_str();

let variant_split = camel_case_split(name);
if variant_split.len() == 1 {
return;
}

pre = pre
.iter()
Expand Down
7 changes: 7 additions & 0 deletions tests/ui/enum_variants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,11 @@ enum North {
NoRight,
}

// #8324
enum Phase {
PreLookup,
Lookup,
PostLookup,
}

fn main() {}

0 comments on commit f4709e6

Please sign in to comment.