Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--help doesn't explain clippy-specific options such as --no-deps #7389

Closed
keiichiw opened this issue Jun 22, 2021 · 1 comment · Fixed by #7492
Closed

--help doesn't explain clippy-specific options such as --no-deps #7389

keiichiw opened this issue Jun 22, 2021 · 1 comment · Fixed by #7492
Assignees
@nfejzic
Labels
A-ui Area: Clippy interface, usage and configuration good-first-issue These issues are a good way to get started with Clippy

Comments

@keiichiw
Copy link

keiichiw commented Jun 22, 2021 •
edited by rustbot
Loading

cargo clippy --help doesn't cover all of supported flags.
Although the help documentation says "Other options are the same as cargo check", there exist some clippy-specific flags such as --fix and --no-deps.
@giraffate giraffate added A-ui Area: Clippy interface, usage and configuration good-first-issue These issues are a good way to get started with Clippy labels Jun 22, 2021
@nfejzic
Copy link
Contributor

nfejzic commented Jul 24, 2021

Hi, I'm new here and would really like to contribute.

@rustbot claim

@nfejzic nfejzic mentioned this issue Jul 25, 2021
Merged
bors added a commit that referenced this issue Jul 27, 2021
@bors
Auto merge of #7492 - nfejzic:improve_help, r=Manishearth
ac0fd99 
Explain flags missing in cargo check in --help

This commit closes #7389. As stated in the issue, `cargo clippy --help`
provides explanation for some flags and states that the rest are same
as in `cargo check --help`, even though some clippy specific flags
exist.

This commit extends the `cargo clippy --help` with two additional flags,
  - `cargo clippy --fix`
  - `cargo clippy --no-deps`

If there are more flags which are not present in `cargo check --help`
please bring these to my attention, I will include these aswell.
For now, I noticed only the two flags mentioned above.

changelog: `cargo clippy --help` now explains additional flags missing in `cargo check --help`.
@bors bors closed this as completed in f68629a Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfejzic nfejzic

Labels
A-ui Area: Clippy interface, usage and configuration good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explain flags missing in cargo check in --help nfejzic/rust-clippy
3 participants
@keiichiw @giraffate @nfejzic