Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAU to approx_constant lint #7641

Closed
ghost opened this issue Sep 6, 2021 · 3 comments
Closed

Add TAU to approx_constant lint #7641

ghost opened this issue Sep 6, 2021 · 3 comments
Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't

Comments

@ghost
Copy link

ghost commented Sep 6, 2021

Lint name: approx_constant

I tried this code:

let two_pi = 6.2833;

I expected to see this happen:
approx_const should recommend using TAU if my version setting is ≥ 1.47.

Instead, this happened:
Nothing. It's a false negative.

@ghost ghost added C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't labels Sep 6, 2021
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2021

Error: Parsing assign command in comment failed: ...'n mikerite' | error: user should start with @ at >| ''...

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbot rustbot assigned ghost Sep 6, 2021
@ghost
Copy link
Author

ghost commented Sep 6, 2021

@rustbot assign @mikerite

@ghost ghost changed the title Add TAU to approx_constant lints Add TAU to approx_constant lint Sep 6, 2021
@ghost
Copy link
Author

ghost commented Sep 7, 2021

Fixed by #7642

@ghost ghost closed this as completed Sep 7, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing I-false-negative Issue: The lint should have been triggered on code, but wasn't
Projects
None yet
Development

No branches or pull requests

1 participant