Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all types supported by [collection_is_never_read] #10627

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

schubart
Copy link
Contributor

@schubart schubart commented Apr 10, 2023

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Apr 10, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 10, 2023
@bors
Copy link
Contributor

bors commented Apr 11, 2023

☔ The latest upstream changes (presumably #10614) made this pull request unmergeable. Please resolve the merge conflicts.

@schubart schubart force-pushed the collection_is_never_read_all_types branch from 46a32e8 to b85deea Compare April 11, 2023 03:28
@schubart
Copy link
Contributor Author

Test all types for which this lint is intended to work, not just String, for which @bluthej kindly fixed a false negative in #10614.

@schubart schubart marked this pull request as ready for review April 11, 2023 03:41
@xFrednet
Copy link
Member

What can I say, it looks perfect to me! Thank you for the addition of tests!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 11, 2023

📌 Commit b85deea has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 11, 2023

⌛ Testing commit b85deea with merge 2a774bb...

@bors
Copy link
Contributor

bors commented Apr 11, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 2a774bb to master...

@bors bors merged commit 2a774bb into rust-lang:master Apr 11, 2023
@schubart schubart deleted the collection_is_never_read_all_types branch April 11, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants