Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unusable_matches_bindings lint #12480

Closed

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 13, 2024

Re-opening of #11661 (original PR is still open but seem dead. Discussion on zulip agreed that I could cherry-pick the commits and make the last changes asked so here we go. :)

changelog: Add new unusable_matches_bindings lint

@rustbot
Copy link
Collaborator

rustbot commented Mar 13, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 13, 2024
@GuillaumeGomez
Copy link
Member Author

Arf, you keep getting picked up. Setting someone else.

r? clippy

@rustbot rustbot assigned Jarcho and unassigned Manishearth Mar 13, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Mar 17, 2024

This would be better as a change to the unused_variables message rather than it's own lint with a second message about the same thing.

@GuillaumeGomez
Copy link
Member Author

Good point.

@GuillaumeGomez
Copy link
Member Author

This is actually already triggered by rustc's unused_variable so can be closed.

@GuillaumeGomez GuillaumeGomez deleted the unusable-matches-binding branch March 17, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants