Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal compiler_lint_functions lint #13056

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

y21
Copy link
Member

@y21 y21 commented Jul 5, 2024

This internal lint has effectively been superseded by disallowed_methods when we started using that in #11811 (I didn't even know that we also had this internal lint at the time of when I created that PR).

Some of the methods that this looks for also don't exist anymore (span_lint_note and span_lint_help), though there was one that that lint had but wasn't disallowed in clippy.toml (LintContext::lint)

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 5, 2024
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 8, 2024

📌 Commit ecbb2d7 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 8, 2024

⌛ Testing commit ecbb2d7 with merge 87f8a5b...

@bors
Copy link
Contributor

bors commented Jul 8, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 87f8a5b to master...

@bors bors merged commit 87f8a5b into rust-lang:master Jul 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants