-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backport, release and sync documentation #13700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing that caught my eye :)
1. [Defining Remotes](#defining-remotes) | ||
1. [Bump Version](#bump-version) | ||
1. [Find the Clippy commit](#find-the-clippy-commit) | ||
1. [Update the `beta` branch](#update-the-beta-branch) | ||
1. [Update the `stable` branch](#update-the-stable-branch) | ||
1. [Tag the stable commit](#tag-the-stable-commit) | ||
1. [Update `CHANGELOG.md`](#update-changelogmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. [Defining Remotes](#defining-remotes) | |
1. [Bump Version](#bump-version) | |
1. [Find the Clippy commit](#find-the-clippy-commit) | |
1. [Update the `beta` branch](#update-the-beta-branch) | |
1. [Update the `stable` branch](#update-the-stable-branch) | |
1. [Tag the stable commit](#tag-the-stable-commit) | |
1. [Update `CHANGELOG.md`](#update-changelogmd) | |
1. [Defining Remotes](#defining-remotes) | |
2. [Bump Version](#bump-version) | |
3. [Find the Clippy commit](#find-the-clippy-commit) | |
4. [Update the `beta` branch](#update-the-beta-branch) | |
5. [Update the `stable` branch](#update-the-stable-branch) | |
6. [Tag the stable commit](#tag-the-stable-commit) | |
7. [Update `CHANGELOG.md`](#update-changelogmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MdBook renders the original source as a correctly ordered list, although it would be cool to have the numbered list even when reading source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with that, so when inserting a new chapter in the future, you don't have to update all the following numbers. But happy to change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR! 🤠 I had comments, some are more important than others. 🌵 (Yeehaw)
1. [Defining Remotes](#defining-remotes) | ||
1. [Bump Version](#bump-version) | ||
1. [Find the Clippy commit](#find-the-clippy-commit) | ||
1. [Update the `beta` branch](#update-the-beta-branch) | ||
1. [Update the `stable` branch](#update-the-stable-branch) | ||
1. [Tag the stable commit](#tag-the-stable-commit) | ||
1. [Update `CHANGELOG.md`](#update-changelogmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MdBook renders the original source as a correctly ordered list, although it would be cool to have the numbered list even when reading source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to change the branch names? 🤔 I think those were fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. rustbot checks all PRs for merge commits and will comment on it, if it finds one. This can be opted out with allowing some PR titles to have merge commits:
Lines 12 to 15 in 8298da7
# Have rustbot inform users about the *No Merge Policy* | |
[no-merges] | |
exclude_titles = ["Rustup"] # exclude syncs from rust-lang/rust | |
labels = ["has-merge-commits", "S-waiting-on-author"] |
In the Clippy repo it is Rustup
, in the Rust repo it is subtree update
.
By using rustup
as a branch name in the Clippy repo and clippy-subtree-update
in the Rust repo, GitHub will automatically set the title when opening the PR to Rustup
and Clippy subtree update
respectively. So rustbot won't complain about these PRs.
@rustbot ready I addressed all comments in 9858a4e, except for #13700 (comment). LMK, if you want me to change that. I'll rebase+squash once the PR is approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️ 🌈
Yeehaw 🤠
@rustbot author |
375026b
to
f5f2c51
Compare
This updates the documentation after #13694. It is not based on that PR chain and can be merged independently, but should be merged after that PR.
This is partly pulled from #12762, but removing the Josh parts.
This includes instructions on how to publish
clippy_utils
.Closes #13556 (yes, this is the final PR 🙂)
r? @blyxyas
changelog:
clippy_utils
is now published to crates.io