Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version of literal_string_with_formatting_args #13974

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

kpreid
Copy link
Contributor

@kpreid kpreid commented Jan 9, 2025

It claims to be in 1.83 but in fact will not be until 1.85.

Evidence: rust-lang/rust#134788 is where it was merged into rust-lang/rust, and has a milestone of 1.85.

changelog: none

It claims to be in 1.83 but in fact will not be until 1.85.

Evidence: <rust-lang/rust#134788> is where it was merged into rust-lang/rust, and has a milestone of 1.85.
@rustbot
Copy link
Collaborator

rustbot commented Jan 9, 2025

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 9, 2025
Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll always be fixed when Frednet does the changelog. However this works now too 👍

@Centri3 Centri3 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into rust-lang:master with commit ab55d3f Jan 10, 2025
12 of 13 checks passed
@kpreid kpreid deleted the patch-2 branch January 11, 2025 02:23
@kpreid
Copy link
Contributor Author

kpreid commented Jan 11, 2025

This'll always be fixed when Frednet does the changelog.

I assume you mean the changelog for 1.85?

My motivation for making this change is that https://rust-lang.github.io/rust-clippy/master/index.html is the most prominently linked form of the Clippy lint documentation, and the documentation one must use when one encounters a new lint on nightly, so anyone who is using nightly (such as myself, together with stable) will be consulting it routinely to deal with new lints. Therefore, for my purposes, and I expect others, it is valuable for the documentation on master to be reasonably accurate at all times, not only upon a release, at least with respect to version and other factors that affect whether a lint will fire. If the version listed is too early, I will incorrectly think “I can allow this” (which would be appropriate for a lint that has expanded to cover more cases) instead of “if I want to allow this I must also allow(unknown_lints) (for new lints).

Waiting for the next release means confusion until the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants