Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #2851

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Version bump #2851

merged 1 commit into from
Jun 18, 2018

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jun 18, 2018

Related PR: rust-lang/rust#51425

//! min_version.txt is in the repo but also in the .gitignore to
//! make sure that it is not updated manually by accident. Only CI
//! should update that file.

I'm not quite sure about CI part.

@oli-obk
Copy link
Contributor

oli-obk commented Jun 18, 2018

Yea... the CI part isn't happening yet, so you'd need to run rustc -vV > min_version.txt manually.

I'll do that locally before publishing.

Thanks for taking care of the entire update process! This makes it much easier for me

@oli-obk oli-obk merged commit 1a6ae4e into rust-lang:master Jun 18, 2018
@mati865
Copy link
Contributor Author

mati865 commented Jun 18, 2018

It could be mentioned in PUBLISH.md or even done by pre_publish.sh until CI part is done.
Just in case somebody else would need to publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants