Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependence of ci on github token #3115

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Remove dependence of ci on github token #3115

merged 1 commit into from
Sep 3, 2018

Conversation

Manishearth
Copy link
Member

@Manishearth
Copy link
Member Author

it wooooorks

@Manishearth
Copy link
Member Author 

stderr: error: unable to unlink old fallback exe
info: caused by: Access is denied. (os error 5)

cc @kennytm looks like the cargo fallback stuff in rustup is failing here. I'm unsure how this used to work previously.

@phansch
Copy link
Member

phansch commented Sep 3, 2018

LGTM! No idea about the unlinking error, though.

@Manishearth Manishearth merged commit 2d0b7db into master Sep 3, 2018
@Manishearth
Copy link
Member Author

I'm merging, it's fine if appveyor is broken

@Manishearth Manishearth deleted the rm-token branch September 3, 2018 05:48
@Manishearth
Copy link
Member Author

(I want working PR CI as soon as possible)

@kennytm
Copy link
Member

kennytm commented Sep 3, 2018

Looks like the unlink error is Windows-only https://github.com/rust-lang-nursery/rustup.rs/blob/22b6cdb8b000f9217af1dd5dd4e73ce032bdb25d/src/rustup/toolchain.rs#L374

@phansch phansch mentioned this pull request Sep 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manishearth @phansch @kennytm