Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the random_state lint. #3635

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

matthiaskrgr
Copy link
Member

Remove the random_state lint until it or rustc has been fixed to no longer crash with debug assertions (see #3628)
We can't update clippy in the rustc repo because of this which is blocking nightlies because toolstate is already broken.

fixes #3628

@matthiaskrgr
Copy link
Member Author

Thanks!
@bors r=xfix

@bors
Copy link
Contributor

bors commented Jan 5, 2019

📌 Commit 8ff4a1f has been approved by xfix

@bors
Copy link
Contributor

bors commented Jan 5, 2019

⌛ Testing commit 8ff4a1f with merge c63b634...

bors added a commit that referenced this pull request Jan 5, 2019
Revert the random_state lint.

Remove the random_state lint until it or rustc has been fixed to no longer crash with debug assertions (see #3628)
We can't update clippy in the rustc repo because of this which is blocking nightlies because toolstate is already broken.

fixes #3628
@bors
Copy link
Contributor

bors commented Jan 5, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: xfix
Pushing c63b634 to master...

@bors bors merged commit 8ff4a1f into rust-lang:master Jan 5, 2019
@bors bors mentioned this pull request Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crashes in used_underscore_binding_macro.rs with debug assertions enabled
3 participants