Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent failing to restart setup-toolchain #5137

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Feb 5, 2020

If rustup-toolchain-install-master fails to install master
toolchain (in case rustup update executes at the same time
it would remove the tmp directory), cargo search (which use
master toolchain after rustup override command) will fail.
This leads to setup-toolchain fails too.

changelog: none

If `rustup-toolchain-install-master` fails to install master
toolchain (in case `rustup update` executes at the same remove the
tmp directory), `cargo search` (which use master toolchain after
`rustup override` command) will fail. This leads to setup-toolchain
fails too.
@flip1995
Copy link
Member

flip1995 commented Feb 5, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Feb 5, 2020

📌 Commit 46df971 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 5, 2020

⌛ Testing commit 46df971 with merge a7b3b9f...

bors added a commit that referenced this pull request Feb 5, 2020
Prevent failing to restart setup-toolchain

If `rustup-toolchain-install-master` fails to install master
toolchain (in case `rustup update` executes at the same remove the
tmp directory), `cargo search` (which use master toolchain after
`rustup override` command) will fail. This leads to setup-toolchain
fails too.

changelog: none
@bors
Copy link
Contributor

bors commented Feb 5, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing a7b3b9f to master...

@bors bors merged commit 46df971 into rust-lang:master Feb 5, 2020
@tesuji tesuji deleted the race branch February 5, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants