[WIP] Extend uninit_assumed_init lint to cover more cases
#5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `uninit_assumed_init` doesn't lint when `assume_init` is invoked on a `MaybeUninit<_>` variable so extending it to cover that case.
krishna-veerareddy
changed the title
uninit_assumed_init lint to cover more casesuninit_assumed_init lint to cover more cases
llogiq
requested changes
Feb 26, 2020
| let _: (MaybeUninit<usize>, MaybeUninit<bool>) = unsafe { x.assume_init() }; | ||
|
|
||
| let x: MaybeUninit<(MaybeUninit<usize>, [MaybeUninit<bool>; 2])> = MaybeUninit::uninit(); | ||
| let _: (MaybeUninit<usize>, [MaybeUninit<bool>; 2]) = unsafe { x.assume_init() }; |
There was a problem hiding this comment.
I'd like to see a false-positive check here, e.g.
let x: MaybeUninit<usize> = MaybeUninit::uninit();
let _ = unsafe {
x.as_mut_ptr().write(42usize);
x.assume_init()
}
There was a problem hiding this comment.
I marked it as WIP as I was just thinking about that. Will need to detect cases where the MaybeUninit variable is initialized before a call to assume_init and ignore that case.
flip1995
added
the
S-waiting-on-author
|
Thanks for contributing to Clippy! Sadly this PR was not updated in quite some time. If you waited on input from a reviewer, we're sorry that this fell under the radar. If you want to continue to work on this, just reopen the PR and/or ping a reviewer. |
flip1995
added
S-inactive-closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
uninit_assumed_initdoesn't lint whenassume_initisinvoked on a
MaybeUninit<_>variable so extending it to cover thatcase.
Fixes #4765
changelog: Extend
uninit_assumed_initto cover more cases