Fix fp in borrow_interior_mutable_const
#5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix false positive when referencing a field behind a pointer.
|
r? @yaahc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ThibsG
reviewed
Aug 24, 2020
Co-authored-by: Thibaud <[email protected]>
yaahc
reviewed
Aug 24, 2020
|
r? @oli-obk on the "referecnes and consts" bit? |
flip1995
approved these changes
Aug 25, 2020
|
@bors r+ yea this makes sense. The only thing I'm wondering is whether we should move this lint to a MIR lint where I think we may be able to write a guaranteed-false-positive-free version since there'd be no more implicit things happening |
|
📌 Commit ce8915c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5796
changelog: fix false positive in
borrow_interior_mutable_constwhen referencing a field behind a pointer.