Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore str::len() in or_fun_call lint. #6950

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

Sciencentistguy
Copy link
Contributor

changelog: Changed or_fun_call to ignore str::len, in the same way it ignores slice::len and array::len

Closes #6943

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 22, 2021
@phansch
Copy link
Member

phansch commented Mar 22, 2021

r? @phansch

@rust-highfive rust-highfive assigned phansch and unassigned flip1995 Mar 22, 2021
@phansch
Copy link
Member

phansch commented Mar 22, 2021

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Mar 22, 2021

📌 Commit 45e7756 has been approved by phansch

@bors
Copy link
Contributor

bors commented Mar 22, 2021

⌛ Testing commit 45e7756 with merge b80903b...

@bors
Copy link
Contributor

bors commented Mar 22, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing b80903b to master...

@bors bors merged commit b80903b into rust-lang:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const functions should not trigger or_fun_call
5 participants