default_numeric_fallback: Fix FP with floating literal

[Y-Nak]

Fix #7445

changelog: default_numeric_fallback: Fix FP with floating literal

[flip1995]

r? @xFrednet Can you take over this review please? (rust-highfive was down, so I'll give the 2 unassigned PRs to you)

[xFrednet]

The changes LGTM.

The FP was a result of tests which only checked for the int type. I've looked through the test file, and it seems to me that the first test cases still miss a float counterpart. Could you also add them as a precaution?

// in the `basic_expr` module
        let x = [1.0, 2.0, 3.0];
        let x = if true { (1.0, 2.0) } else { (3.0, 4.0) };
        let x = match 1.0 {
            1.0 => 1.0,
            _ => 2.0,
        };
 // in the `nested_local` module
         let x: _ = {
            // Should lint this because this literal is not bound to any types.
            let y = 1.0;

            // Should NOT lint this because this literal is bound to `_` of outer `Local`.
            1.0
        };

[Y-Nak]

Changes:

1. Add more test cases for floating literal
2. Split the i32 and f64 test cases into their own files, otherwise cargo dev limit_stderr_length fails

[xFrednet]

LGTM, thank you for the quick fixes and nice work!

@flip1995 I would hand it over to you now :)

[Y-Nak]

Changes:

• Fix NumericLiteral::format, there was a possibility of producing invalid literals like 1._f32
• Remove duplication of #![allow(clippy::branches_sharing_code)]
• Add // run-rustfix

[flip1995]

One more NIT

[flip1995]

Formattings:

Suggested change

	let src = if let Some(src) = snippet_opt(self.cx, lit.span){
	src
	} else {
	match lit.node {
	LitKind::Int(src, _) =>format!("{}", src),
	LitKind::Float(src, _) => format!("{}", src),
	_ => { return; }
	}
	let src = if let Some(src) = snippet_opt(self.cx, lit.span) {
	src
	} else {
	match lit.node {
	LitKind::Int(src, _) => format!("{}", src),
	LitKind::Float(src, _) => format!("{}", src),
	_ => return,
	}

[Y-Nak]

Fixed.

Just a question:
Could you tell me how do you find formatting problems inside if_chain? Is there a good way(e.g. editor support) for that.

[flip1995]

I don't know of anything that would help here. Maybe implementing formatting rules in rustfmt for the if_chain macro. Not sure if that would be accepted there though, since this isn't a std macro.

[Y-Nak]

I understand. Thanks for the answer!

[flip1995]

@bors r=xFrednet,flip1995

Thanks!

[bors]

📌 Commit 25e4c7d has been approved by xFrednet,flip1995

[bors]

⌛ Testing commit 25e4c7d with merge 8131445...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet,flip1995
Pushing 8131445 to master...