Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle Self type for trivially_copy_pass_by_ref #7535

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

LeSeulArtichaut
Copy link
Contributor

changelog: properly handle Self type for [trivially_copy_pass_by_ref].

Fixes #7518

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 5, 2021
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the work! 🙃 🐧

@xFrednet
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 10, 2021

📌 Commit ccb5d73 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Aug 10, 2021

⌛ Testing commit ccb5d73 with merge 76c4a33...

@bors
Copy link
Contributor

bors commented Aug 10, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 76c4a33 to master...

@bors bors merged commit 76c4a33 into rust-lang:master Aug 10, 2021
@LeSeulArtichaut LeSeulArtichaut deleted the 7518-self-ty-arg branch August 11, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trivially_copy_pass_by_ref makes suggestion that does not compile
5 participants