Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint suspicious_else_formatting inside proc-macros #7707

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Sep 23, 2021

fixes: #7650

I'll add a test for this one soon.

changelog: Don't lint suspicious_else_formatting inside proc-macros

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2021
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll wait for the test before landing

@Jarcho Jarcho force-pushed the suspicious_else_proc_mac branch from 90766f3 to 5efd6bc Compare September 23, 2021 05:13
@Jarcho Jarcho force-pushed the suspicious_else_proc_mac branch from 1f5539d to e69154f Compare September 23, 2021 15:23
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Sep 23, 2021

📌 Commit e69154f has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Sep 23, 2021

⌛ Testing commit e69154f with merge cd3f3cf...

@bors
Copy link
Contributor

bors commented Sep 23, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing cd3f3cf to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::suspicious_else_formatting reports some Enums (?!)
4 participants