Add MSRV to deprecated_cfg_attr #7944
Conversation
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| )); | ||
| None | ||
| }) | ||
| }); |
There was a problem hiding this comment.
I don't like copying these lines. Is there a reason these 3 lints can't just be a part of register_plugins?
There was a problem hiding this comment.
There seems to be no specific reason. IMHO, as the comments says, It might be easier to keep them separate as separate functions as they are now, since it is desirable that they are eventually removed.
There was a problem hiding this comment.
Can you add a test and update clippy_lints/src/utils/conf.rs? Here is a reference:
https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md#specifying-the-lints-minimum-supported-rust-version-msrv
Serial-ATA
force-pushed
the
deprecated-cfg-attr-msrv
branch
from
3e13c10 to
0f24721
Compare
Serial-ATA
force-pushed
the
deprecated-cfg-attr-msrv
branch
from
0f24721 to
413d255
Compare
|
@bors r+ Thanks! |
|
📌 Commit 413d255 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: Add MSRV to [
deprecated_cfg_attr]closes: #7922