Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cover trait for trait_duplication_in_bounds #8252

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Conversation

dswij
Copy link
Member

@dswij dswij commented Jan 9, 2022

closes #8229

changelog: [trait_duplication_in_bounds] covers trait functions with Self bounds

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 9, 2022
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, just three smaller comments 🙃.

I also ran lintcheck, and we had no ICEs and no reports 👍

tests/ui/trait_duplication_in_bounds.rs Show resolved Hide resolved
clippy_lints/src/trait_bounds.rs Show resolved Hide resolved
tests/ui/trait_duplication_in_bounds.stderr Outdated Show resolved Hide resolved
@xFrednet
Copy link
Member

Looks good to me! Thank you for the changes 🙃

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2022

📌 Commit f4dc348 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented Jan 10, 2022

⌛ Testing commit f4dc348 with merge 88cfd70...

@bors
Copy link
Contributor

bors commented Jan 10, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 88cfd70 to master...

@bors bors merged commit 88cfd70 into rust-lang:master Jan 10, 2022
@dswij dswij deleted the 8229 branch January 11, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn about supertrait bound duplicated in function trait bound (where Self: Supertrait)
4 participants