Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix misspelling in diagnostic message of bytes_nth #8403

Merged

Conversation

oppiliappan
Copy link
Contributor

Please write a short comment explaining your change (or "none" for internal only changes)

changelog: fix misspelling in diagnostic message in [`bytes_nth`]

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 8, 2022
@flip1995
Copy link
Member

flip1995 commented Feb 8, 2022

You'll have to run cargo uitest and cargo dev bless and then also commit the changes to the stderr file(s) (optimally all squashed into a single commit).

@oppiliappan
Copy link
Contributor Author

Ah, thanks for the pointer @flip1995

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ but needs test updates

@giraffate
Copy link
Contributor

@nerdypepper ping from triage. Can you have any question on this?

@flip1995 flip1995 force-pushed the fix/diagnostic-message-mispelling branch from 9f2517e to 1582e7b Compare April 5, 2022 09:54
@flip1995
Copy link
Member

flip1995 commented Apr 5, 2022

I updated the tests for you. Thanks for catching this!

@bors r=flip1995,Manishearth

@bors
Copy link
Contributor

bors commented Apr 5, 2022

📌 Commit 1582e7b has been approved by flip1995,Manishearth

@bors
Copy link
Contributor

bors commented Apr 5, 2022

⌛ Testing commit 1582e7b with merge 938b9fd...

@bors
Copy link
Contributor

bors commented Apr 5, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995,Manishearth
Pushing 938b9fd to master...

@bors bors merged commit 938b9fd into rust-lang:master Apr 5, 2022
@oppiliappan
Copy link
Contributor Author

sorry for not acting on this sooner, didn't get the time to setup my dev environment, thanks for picking it up @flip1995!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants