wrong_self_convention allows is_* to take &mut self
#8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
approved these changes
Apr 24, 2022
|
LGTM, thank you for the fix! 👍 For future reference, this is something worthy of a changelog entry. I've edited the description to r+ it now. If you're unsure what belongs into the changelog you're always welcome to ask. Otherwise, it's usually better to include too much information than to little 🙃 @bors r+ |
|
📌 Commit 51db157 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
@xFrednet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8480 and #8513
Allowing
is_*to take&selfor none is too restrictive.changelog: FPs: [
wrong_self_convention] now allows&mut selfand no self as arguments foris_*methods