-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for --force-warn
in Clippy's driver run condition
#9036
Conversation
r? @dswij (rust-highfive has picked a reviewer for you, use r? to override) |
dc95092
to
af31c1e
Compare
af31c1e
to
67443f6
Compare
67443f6
to
4182803
Compare
If I understand it correctly, will this change means that |
Yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. LGTM, thanks for this!
Thanks for the review! Is there anything else that needs to be done before the merge or did you forget to r+? 🙃 |
Oops, you're right 😅 @bors r+ |
📌 Commit 4182803 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Just a thing I've noticed while tinkering on the driver. Currently, the driver only checks for
--cap-lints=allow
to determine if Clippy should run on the code, but ignores possible--force-warn
argumentschangelog: Others: Allowing all lints and only
--force-warn
ing some will now work with Clippy's driver