Fix incorrect uninlined_format_args edge case #9588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @Alexendoo |
|
☔ The latest upstream changes (presumably #9547) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #9586) made this pull request unmergeable. Please resolve the merge conflicts. |
An edge case with format arguments being wrapped in parentesis
|
closing because now all tests pass thx to #9586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An edge case with format arguments being wrapped in parenthesis. This might have been the real reason behind the #9540.
Note that this changelog line might be irrelevant if the uninlined_format_args itself is added in the same release as this patch.
changelog[
uninlined_format_args]: fix minor bug not handling params in parethethiscc: @Alexendoo