Skip to content

Commit

Permalink
Rollup merge of #56758 - Manishearth:emoji-status-toolstate, r=kennytm
Browse files Browse the repository at this point in the history
Add short emoji status to toolstate updates

I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly

I haven't been able to test it, and the actual emoji are just suggestions.

r? @kennytm

cc @rust-lang/infra @rust-lang/devtools
  • Loading branch information
pietroalbini authored Dec 15, 2018
2 parents c530e31 + ae893bb commit 050bb10
Showing 1 changed file with 25 additions and 7 deletions.
32 changes: 25 additions & 7 deletions src/tools/publish_toolstate.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,16 @@
'rust-by-example': '@steveklabnik @marioidival @projektir',
}

EMOJI = {
'miri': '🛰️',
'clippy-driver': '📎',
'rls': '💻',
'rustfmt': '📝',
'book': '📖',
'nomicon': '👿',
'reference': '📚',
'rust-by-example': '👩‍🏫',
}

def read_current_status(current_commit, path):
'''Reads build status of `current_commit` from content of `history/*.tsv`
Expand Down Expand Up @@ -63,13 +73,12 @@ def update_latest(
}

slug = 'rust-lang/rust'
message = textwrap.dedent('''\
📣 Toolstate changed by {}!
long_message = textwrap.dedent('''\
Tested on commit {}@{}.
Direct link to PR: <{}>
''').format(relevant_pr_number, slug, current_commit, relevant_pr_url)
''').format(slug, current_commit, relevant_pr_url)
emoji_status = []
anything_changed = False
for status in latest:
tool = status['tool']
Expand All @@ -81,12 +90,18 @@ def update_latest(
status[os] = new
if new > old:
changed = True
message += '🎉 {} on {}: {} → {} (cc {}, @rust-lang/infra).\n' \
.format(tool, os, old, new, MAINTAINERS.get(tool))
long_message += '🎉 {} on {}: {} → {}.\n' \
.format(tool, os, old, new)
emoji = "{}🎉".format(EMOJI.get(tool))
if msg not in emoji_status:
emoji_status += [msg]
elif new < old:
changed = True
message += '💔 {} on {}: {} → {} (cc {}, @rust-lang/infra).\n' \
long_message += '💔 {} on {}: {} → {} (cc {}, @rust-lang/infra).\n' \
.format(tool, os, old, new, MAINTAINERS.get(tool))
emoji = "{}💔".format(EMOJI.get(tool))
if msg not in emoji_status:
emoji_status += [msg]

if changed:
status['commit'] = current_commit
Expand All @@ -96,6 +111,9 @@ def update_latest(
if not anything_changed:
return ''

short_message = "📣 Toolstate changed by {}! ({})"
.format(relevant_pr_number, '/'.join(emoji_status))
message = short_message + "\n\n" + long_message
f.seek(0)
f.truncate(0)
json.dump(latest, f, indent=4, separators=(',', ': '))
Expand Down

0 comments on commit 050bb10

Please sign in to comment.