Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Json doesn't need to depend on IoError to implement Encodable #13230
- Loading branch information
2deca58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from erickt
at Kroisse@2deca58
2deca58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging Kroisse/rust/encodable-json = 2deca58 into auto
2deca58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kroisse/rust/encodable-json = 2deca58 merged ok, testing candidate = ba2fcc1
2deca58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4976
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4979
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/4070
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4082
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/5078
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/4163
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4171
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/5078
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/4163
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4168
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4234
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1966
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/5075
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4173
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4183
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4840
2deca58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = ba2fcc1