Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ and - keyboard shortcuts mixed up in docs page #102772

Closed
amab8901 opened this issue Oct 7, 2022 · 3 comments · Fixed by #103296
Closed

+ and - keyboard shortcuts mixed up in docs page #102772

amab8901 opened this issue Oct 7, 2022 · 3 comments · Fixed by #103296
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@amab8901
Copy link
Contributor

amab8901 commented Oct 7, 2022

Take any page in the Rust docs, for example this. When you press the + or - keyboard shortcuts on your keyboard, they are supposed to either collapse or expand all items on the page, but not both (according to the instructions that you can find by clicking ? on your keyboard (or on the screen).

Please make the + and - keyboard shortcuts idempotent, otherwise it would be redundant to have two buttons that do the same thing.
@amab8901 amab8901 added the C-bug Category: This is a bug. label Oct 7, 2022
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 19, 2022
@GuillaumeGomez
Copy link
Member

What do you think about this @Manishearth @jsha ?

@Manishearth
Copy link
Member

Yeah we should do this.

@GuillaumeGomez
Copy link
Member

I'll send a patch in the next days then.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 20, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#103296 - GuillaumeGomez:collapse-expand-sho…
a13a000 
…rtcuts, r=notriddle

+/- shortcut now only expand/collapse, not both

Fixes rust-lang#102772.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#103296 - GuillaumeGomez:collapse-expand-sho…
de9b7e5 
…rtcuts, r=notriddle

+/- shortcut now only expand/collapse, not both

Fixes rust-lang#102772.

r? ``@notriddle``
@bors bors closed this as completed in 5bf18ad Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

+/- shortcut now only expand/collapse, not both GuillaumeGomez/rust
3 participants
@Manishearth @GuillaumeGomez @amab8901