Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to pass bench/shootout-k-nucleotide-pipes.rs on android #10393

Closed
yichoi opened this issue Nov 10, 2013 · 5 comments
Closed

fix to pass bench/shootout-k-nucleotide-pipes.rs on android #10393

yichoi opened this issue Nov 10, 2013 · 5 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android

Comments

@yichoi
Copy link
Contributor

yichoi commented Nov 10, 2013

To enable test on android bot #9120

It is not fininshed on android
@huonw
Copy link
Member

huonw commented Nov 10, 2013

Would it be possible to give more details about why these tests are failing? (e.g. pasted output.)

@yichoi
Copy link
Contributor Author

yichoi commented Nov 10, 2013

no console output but hanging forever. is there other way to generate output ?

@huonw
Copy link
Member

huonw commented Nov 10, 2013

@yichoi that's good, just some description of the exact issue. For example, so that people triaging later know what they're looking for to work out if a bug is fixed or not.

@TeXitoi TeXitoi mentioned this issue Mar 30, 2014
Merged
@flaper87
Copy link
Contributor

Triage bump: The tests are still being ignored for android.

tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
c261a07
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
598f7e0 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
1b9733a
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
0b34389 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
82387d1
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
023d199 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
dc09778
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable tests on Android
7c24a34 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 23, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
dae240f
tamird added a commit to tamird/rust that referenced this issue Apr 23, 2015
@tamird
Re-enable tests on Android
bfb97f2 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 24, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
3340007
tamird added a commit to tamird/rust that referenced this issue Apr 24, 2015
@tamird
Re-enable tests on Android
f4dd361 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 25, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
4648036
tamird added a commit to tamird/rust that referenced this issue Apr 25, 2015
@tamird
Re-enable tests on Android
292a090 
Closes rust-lang#10393.
tamird added a commit to tamird/rust that referenced this issue Apr 29, 2015
@tamird
rust-lang#10393 & rust-lang#13206: Warnings
41ff911
@steveklabnik
Copy link
Member

Triage: #31274 removed all of src/test/bench, so this is no longer ignored 😛

flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 8, 2024
@bors
Auto merge of rust-lang#12084 - yuxqiu:manual_retain, r=Alexendoo
8ccf6a6 
fix: incorrect suggestions generated by `manual_retain` lint

fixes rust-lang#10393, fixes rust-lang#11457, fixes rust-lang#12081

rust-lang#10393: In the current implementation of `manual_retain`, if the argument to the closure is matched using tuple, they are all treated as the result of a call to `map.into_iter().filter(<f>)`. However, such tuple pattern matching can also occur in many different containers that stores tuples internally. The correct approach is to apply different lint policies depending on whether the receiver of `into_iter` is a map or not.

rust-lang#11457 and rust-lang#12081: In the current implementation of `manual_retain`, if the argument to the closure is `Binding`, the closure will be used directly in the `retain` method, which will result in incorrect suggestion because the first argument to the `retain` closure may be of a different type. In addition, if the argument to the closure is `Ref + Binding`, the lint will simply remove the `Ref` part and use the `Binding` part as the argument to the new closure, which will lead to bad suggestion for the same reason. The correct approach is to detect each of these cases and apply lint suggestions conservatively.

changelog: [`manual_retain`] refactor and add check for various patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flaper87 @steveklabnik @huonw @yichoi