-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: failed to normalize #107872
Comments
Considering this errors with rustc, and rustdoc can only document rust code that actually compiles, I'd say this is in the same bucket as the other issues we have open about this, meaning "not a bug, just a papercut"? |
this is not true |
I can only document code that compiles, ignoring method bodies. This specific test has no method bodies, so does it fall under that rule? |
That seems possible, but you should test to make sure. Rustdoc's logic around this is extremely janky and indirect. |
What is the benefit of documenting code that does not compile? |
I can't keep having this argument. Please read the documentation. |
Triage: No longer ICEs. Might need regression test, not sure. Current compiler output:
|
Rollup merge of rust-lang#130173 - fmease:rustdoc-regression-tests, r=notriddle rustdoc: add two regression tests They were basically copy/pasted from `tests/ui/` to `tests/rustdoc-ui/`. Not sure if it's worth adding these, I can just close these issues as is if you want. This brings the number of https://github.com/rust-lang/rust/labels/T-rustdoc + https://github.com/rust-lang/rust/labels/E-needs-test from 3 down to 1. The remaining one – rust-lang#103004 — is a nasty one to retroactively find a proper(!) test for. Fixes rust-lang#98250. Fixes rust-lang#107872. r? rustdoc
Code
./tests/ui/union/projection-as-union-type-error.rs
Meta
rustc --version --verbose
:Regression in #106938
Error output
Backtrace
The text was updated successfully, but these errors were encountered: