Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc search is broken #118242

Closed
arifd opened this issue Nov 24, 2023 · 1 comment · Fixed by #118251
Closed

rustdoc search is broken #118242

arifd opened this issue Nov 24, 2023 · 1 comment · Fixed by #118251
Labels
A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@arifd
Copy link

arifd commented Nov 24, 2023

sqlx was updated yesterday. and its search is now broken.

compare: https://docs.rs/sqlx/latest/sqlx/?search=types

with: https://docs.rs/sqlx/0.7.2/sqlx/index.html?search=types
@arifd arifd added the C-bug Category: This is a bug. label Nov 24, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 24, 2023
@Urgau
Copy link
Member

Urgau commented Nov 24, 2023

Firefox prints those errors:

Uncaught InternalError: too much recursion
    unifyFunctionTypeIsUnboxCandidate https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    unifyFunctionTypes https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    checkType https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    checkIfInList https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    unifyFunctionTypeIsUnboxCandidate https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    unifyFunctionTypes https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    checkType https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    checkIfInList https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    unifyFunctionTypeIsUnboxCandidate https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    unifyFunctionTypes https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1
    checkType https://docs.rs/-/rustdoc.static/search-f4028ef4dd0903c7.js:1

with rustdoc 1.76.0-nightly (1e9dda77b 2023-11-22)

@rustbot label -needs-triage +T-rustdoc +A-rustdoc-search +regression-untriaged
cc @notriddle

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature regression-untriaged Untriaged performance or correctness regression. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-prioritize Issue: Indicates that prioritization has been requested for this issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 24, 2023
@notriddle notriddle mentioned this issue Nov 24, 2023
Merged
notriddle added a commit to notriddle/rust that referenced this issue Nov 24, 2023
@notriddle
rustdoc-search: avoid infinite where clause unbox
d220bf1 
Fixes rust-lang#118242
notriddle added a commit to notriddle/rust that referenced this issue Nov 24, 2023
@notriddle
rustdoc-search: avoid infinite where clause unbox
20a9940 
Fixes rust-lang#118242
fmease added a commit to fmease/rust that referenced this issue Nov 25, 2023
@fmease
Rollup merge of rust-lang#118251 - notriddle:notriddle/less-recursion…
0304aac 
…, r=GuillaumeGomez

rustdoc-search: avoid infinite where clause unbox

Fixes rust-lang#118242
@bors bors closed this as completed in 1b7b954 Nov 25, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 25, 2023
@rust-timer
Unrolled build for rust-lang#118251
75c5ae6 
Rollup merge of rust-lang#118251 - notriddle:notriddle/less-recursion, r=GuillaumeGomez

rustdoc-search: avoid infinite where clause unbox

Fixes rust-lang#118242
@abonander abonander mentioned this issue Nov 26, 2023
Closed
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-search Area: Rustdoc's search feature C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc-search: avoid infinite where clause unbox notriddle/rust
4 participants
@arifd @Urgau @apiraino @rustbot