[discussion] ErrorKind::CrossesDevices from io_error_more
#130191
Comments
rustbot
added
needs-triage
dtolnay
added
the
T-libs-api
|
@rfcbot fcp merge I propose stabilizing Alternatively, if 2 other team members prefer a rename to |
|
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
jieyouxu
removed
the
needs-triage
|
Checked my box for |
|
Ping @Amanieu @BurntSushi @m-ou-se |
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
…lnay Stabilize `std::io::ErrorKind::CrossesDevices` FCP in rust-lang#130191 cc rust-lang#86442 See rust-lang#130191 for more info and a recap of what has happened up until now. TLDR: This had been FCP'd in December 2022 with some other `ErrorKind`s, but the stabilization got postponed due to some concerns voiced about several of the variants. However, the only concern ever voiced for this variant in particular was a wish to rename this to `NotSameDevice` analogous to Windows's `ERROR_NOT_SAME_DEVICE` (as opposed to Unix's `EXDEV`). This suggestion did not receive any support. So let's try to FCP this as is. r? libs-api
Rollup merge of rust-lang#130209 - GrigorenkoPV:CrossesDevices, r=dtolnay Stabilize `std::io::ErrorKind::CrossesDevices` FCP in rust-lang#130191 cc rust-lang#86442 See rust-lang#130191 for more info and a recap of what has happened up until now. TLDR: This had been FCP'd in December 2022 with some other `ErrorKind`s, but the stabilization got postponed due to some concerns voiced about several of the variants. However, the only concern ever voiced for this variant in particular was a wish to rename this to `NotSameDevice` analogous to Windows's `ERROR_NOT_SAME_DEVICE` (as opposed to Unix's `EXDEV`). This suggestion did not receive any support. So let's try to FCP this as is. r? libs-api
|
Stabilized in #130209, closing. |
@rustbot label C-discussion
Main tracking issue: #86442
Background
The
io_error_morefeature introduced 21 new variants intoErrorKind. They were FCP'd back in December 2022, but there appeared to be quite a lot of disagreement about 4 of the added variants, so the stabilization (#106375) got stalled for over twenty months. Thankfully, the 17 uncontroversial variants got stabilized in #128316, so now we just need to iron out a satisfactory design for the remaining 4 variants, and then they can be stabilized too.In order to not block any of the remaining variants on each other and to not intertwine the discussions, I've created 4 separate issues, which summarize the concerns & suggestions voiced up until this point and can serve as a place for further discussion.
FilesystemLoop: [discussion]ErrorKind::FilesystemLoopfromio_error_more#130188FilesystemQuotaExceeded: [discussion]ErrorKind::FilesystemQuotaExceededfromio_error_more#130190CrossesDevices: you are hereInvalidFilename: [discussion]ErrorKind::InvalidFilenamefromio_error_more#130192CrossesDevicesCurrently corresponds to
EXDEVon Unix andERROR_NOT_SAME_DEVICEon Windows. (#86442 (comment))Current docs description:
NotSameDeviceOriginally posted by kalcutter in #86442 (comment)
Originally posted by kalcutter in #106375 (comment)
Originally posted by Josh Triplett in #106375 (comment)
The text was updated successfully, but these errors were encountered: