Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop passing spans around in trans #1415

Closed
marijnh opened this issue Jan 2, 2012 · 3 comments
Closed

Stop passing spans around in trans #1415

marijnh opened this issue Jan 2, 2012 · 3 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@marijnh
Copy link
Contributor

marijnh commented Jan 2, 2012

These spans are only used in output generated when hitting an unexpected circumstance (compiler bug). Passing them around is cumbersome, and already being done very poorly (the association of spans with block contexts is completely busted), so I think the code is better off without it.
@ghost ghost assigned marijnh Jan 2, 2012
@marijnh marijnh mentioned this issue Jan 2, 2012
Closed
@jdm
Copy link
Contributor

jdm commented Jan 2, 2012

They're also used for generating debug information about blocks at the moment.

@marijnh
Copy link
Contributor Author

marijnh commented Jan 3, 2012

Ah, that's a more valid use. Hrm... I then vote we remove them from the type_of_* functions (which account for most of the awkwardness), and fix the way we pass them to whichever functions end up generating the debug info.

@marijnh
Copy link
Contributor Author

marijnh commented Jan 27, 2012

Closed by b3f06c7

@marijnh marijnh closed this as completed Jan 27, 2012
@marijnh marijnh removed their assignment Jun 16, 2014
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @zhassan-aws
Deprecate any_raw and Invariant (rust-lang#1415)
e151d22 
* Add perf tests for kani::any() implementations

Also change script to use release build instead of regular build.

* Deprecate any_raw and Invariant

Basically invariant type was only safe for T that had no invalid
value independent on its binary values. All other types had some sort of
UB involved. Thus, deprecate this for now.

Note that we will likely want the Invariant type reintroduced one day,
but we might need to either change its form or ensure that `any_raw()`
at least respect `primitives` and `std` type invariants to avoid users
having to explicitly check for any potential UB (which in itself is UB).

Co-authored-by: Zyad Hassan <[email protected]>
@jieyouxu jieyouxu mentioned this issue Feb 28, 2025
Merged
jieyouxu added a commit to jieyouxu/rust that referenced this issue Feb 28, 2025
@jieyouxu
Rollup merge of rust-lang#137788 - jieyouxu:bump-compiler-cc, r=lqd,K…
46f5dea 
…obzol

Bump `rustc_{codegen_ssa,llvm}` `cc` to 1.2.16 to fix `x86` Windows jobs on newest Windows SDK

Part of rust-lang#137733.

Bump `rustc_{codegen_ssa,llvm}` `cc` to 1.2.16 which contains rust-lang/cc-rs#1425 to help with rust-lang#137733. Previously tested in rust-lang#137724.

#### `cc` changelog between 1.2.13 and 1.2.16

<details>
<summary>`cc` changes since 1.2.13 up to and including 1.2.16</summary>

##### [1.2.16](rust-lang/cc-rs@cc-v1.2.15...cc-v1.2.16) - 2025-02-28

###### Fixed

- force windows compiler to run in `out_dir` to prevent artifacts in cwd (rust-lang#1415)

###### Other

- use `/arch:SSE2` for `x86` target arch (rust-lang#1425)
- Regenerate windows-sys binding ([rust-lang#1422](rust-lang/cc-rs#1422))
- Regenerate target info ([rust-lang#1418](rust-lang/cc-rs#1418))
- Add LIB var when compiling flag_check (rust-lang#1417)
- Change flag ordering ([rust-lang#1403](rust-lang/cc-rs#1403))
- Fix archiver detection for musl cross compilation ([rust-lang#1404](rust-lang/cc-rs#1404))

##### [1.2.15](rust-lang/cc-rs@cc-v1.2.14...cc-v1.2.15) - 2025-02-21

###### Other

- Regenerate target info ([rust-lang#1406](rust-lang/cc-rs#1406))
- Always read from all `CFLAGS`-style flags ([rust-lang#1401](rust-lang/cc-rs#1401))
- Simplify the error output on failed `Command` invocation ([rust-lang#1397](rust-lang/cc-rs#1397))

##### [1.2.14](rust-lang/cc-rs@cc-v1.2.13...cc-v1.2.14) - 2025-02-14

###### Other

- Regenerate target info ([rust-lang#1398](rust-lang/cc-rs#1398))
- Add support for setting `-gdwarf-{version}` based on RUSTFLAGS ([rust-lang#1395](rust-lang/cc-rs#1395))
- Add support for alternative network stack io-sock on QNX 7.1 aarch64 and x86_64 ([rust-lang#1312](rust-lang/cc-rs#1312))

</details>

r? `@Kobzol`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 28, 2025
@rust-timer
Unrolled build for rust-lang#137788
166504f 
Rollup merge of rust-lang#137788 - jieyouxu:bump-compiler-cc, r=lqd,Kobzol

Bump `rustc_{codegen_ssa,llvm}` `cc` to 1.2.16 to fix `x86` Windows jobs on newest Windows SDK

Part of rust-lang#137733.

Bump `rustc_{codegen_ssa,llvm}` `cc` to 1.2.16 which contains rust-lang/cc-rs#1425 to help with rust-lang#137733. Previously tested in rust-lang#137724.

#### `cc` changelog between 1.2.13 and 1.2.16

<details>
<summary>`cc` changes since 1.2.13 up to and including 1.2.16</summary>

##### [1.2.16](rust-lang/cc-rs@cc-v1.2.15...cc-v1.2.16) - 2025-02-28

###### Fixed

- force windows compiler to run in `out_dir` to prevent artifacts in cwd (rust-lang#1415)

###### Other

- use `/arch:SSE2` for `x86` target arch (rust-lang#1425)
- Regenerate windows-sys binding ([rust-lang#1422](rust-lang/cc-rs#1422))
- Regenerate target info ([rust-lang#1418](rust-lang/cc-rs#1418))
- Add LIB var when compiling flag_check (rust-lang#1417)
- Change flag ordering ([rust-lang#1403](rust-lang/cc-rs#1403))
- Fix archiver detection for musl cross compilation ([rust-lang#1404](rust-lang/cc-rs#1404))

##### [1.2.15](rust-lang/cc-rs@cc-v1.2.14...cc-v1.2.15) - 2025-02-21

###### Other

- Regenerate target info ([rust-lang#1406](rust-lang/cc-rs#1406))
- Always read from all `CFLAGS`-style flags ([rust-lang#1401](rust-lang/cc-rs#1401))
- Simplify the error output on failed `Command` invocation ([rust-lang#1397](rust-lang/cc-rs#1397))

##### [1.2.14](rust-lang/cc-rs@cc-v1.2.13...cc-v1.2.14) - 2025-02-14

###### Other

- Regenerate target info ([rust-lang#1398](rust-lang/cc-rs#1398))
- Add support for setting `-gdwarf-{version}` based on RUSTFLAGS ([rust-lang#1395](rust-lang/cc-rs#1395))
- Add support for alternative network stack io-sock on QNX 7.1 aarch64 and x86_64 ([rust-lang#1312](rust-lang/cc-rs#1312))

</details>

r? `@Kobzol`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @marijnh