-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antlr is losing information #15677
Comments
traige: no changes that i'm aware of |
While we still have ANTLR grammar in tree, it is outdated and we predominantly rely on the other one we have in tree. Perhaps we should just remove ANTLR one now? |
The ANTLR grammar was originally intended to be "pure" in the sense that it uses only language description and no code in its operation, and could easily be lifted into some formalism. This is quite at odds with how the flex and bison files operate. |
I would be okay removing ANTLR. On Mar 17, 2016, 05:47 -0400, [email protected], wrote:
|
ANTLR grammar is still in-tree. There is now an answer to the SO question, though, so perhaps that's significant to this discussion? It's possible the easiest answer here is to simply remove the ANTLR grammar from in-tree, possibly moving it elsewhere. |
Agreed; I'd be happy to just remove it. We're not planning on doing anything with ANTLR in the future that I know of, and if we need it, we can pull it back out of the history. |
…ikomatsakis Remove ANTLR grammar I *think* that nothing in-tree references this, but I may be wrong. If anyone thinks of anything, please let me know and I'll work on removing. Fixes rust-lang#15677.
Allocate ast ids for parameters Since these can have attributes attached to them, we'll need this sooner or later (sooner being me tinkering with the token map right now)
See http://stackoverflow.com/questions/24747360/distinguishing-literal-n-vs-embedded-newline. Until there is a resolution to this, the lexer verification is ignoring the contents every token that carries data :(
The text was updated successfully, but these errors were encountered: