Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tidy could detect empty files #18439

Closed
huonw opened this issue Oct 29, 2014 · 5 comments
Closed

make tidy could detect empty files #18439

huonw opened this issue Oct 29, 2014 · 5 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@huonw
Copy link
Member

huonw commented Oct 29, 2014

e.g. #18438.
@iKevinY
Copy link
Contributor

iKevinY commented Mar 22, 2015

I was looking to implement this, but I noticed that compiler-lookup-paths/native.c appears to be intentionally empty. What categories of file should be included/excluded from this check?

@steveklabnik
Copy link
Member

Triage: i am not aware of any changes here. The file @iKevinY mentions is still empty.

@Mark-Simulacrum
Copy link
Member

File that is mentioned isn't empty. I think that this should be a relatively easy thing to implement. In src/tools/tidy/src/style.rs, a check that contents are not empty should be added here. The tidy_error macro can be used to print out the problem. At that point, you'll need to run the tidy script (./x.py test src/tools/tidy), and open a PR listing any new errors uncovered by this.

Please let us know if you plan to work on this by leaving a comment here. If you need any help, please ping me in this issue or on IRC (#rust-internals on irc.mozilla.org, name is simulacrum).

@Mark-Simulacrum Mark-Simulacrum added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels May 12, 2017
@iKevinY
Copy link
Contributor

iKevinY commented May 12, 2017

I should be able to pick up this issue again.

@iKevinY iKevinY mentioned this issue May 12, 2017
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue May 13, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41935 - iKevinY:detect-empty-files, r=Mark-…
ac02b64 
…Simulacrum

Add tidy check to detect empty files

Addresses rust-lang#18439.
@iKevinY
Copy link
Contributor

iKevinY commented May 13, 2017

@Mark-Simulacrum I think this can be closed now that #41935 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @alexcrichton @huonw @iKevinY @Mark-Simulacrum