Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check-build-lexer-verifier fails currently #22379

Closed
frewsxcv opened this issue Feb 15, 2015 · 4 comments
Closed

make check-build-lexer-verifier fails currently #22379

frewsxcv opened this issue Feb 15, 2015 · 4 comments

Comments

@frewsxcv
Copy link
Member

cfg: version 1.0.0-dev (342ab53bf 2015-02-15 12:20:31 +0000)
cfg: build triple x86_64-apple-darwin
cfg: host triples x86_64-apple-darwin
cfg: target triples x86_64-apple-darwin
cfg: enabling more debugging (CFG_ENABLE_DEBUG)
cfg: host for x86_64-apple-darwin is x86_64
cfg: os for x86_64-apple-darwin is apple-darwin
cfg: good valgrind for x86_64-apple-darwin is
cfg: using CC=clang (CFG_CC)
cfg: using CXX=clang++ (CFG_CXX)
cfg: enabling valgrind run-pass tests (CFG_ENABLE_VALGRIND_RPASS)
cfg: valgrind-rpass command set to
cfg: no xelatex found, disabling LaTeX docs
cfg: including test rules
cfg: antlr4 not available, skipping lexer test...
/Users/coreyf/Development/rust/rust/src/grammar/verify.rs:20:5: 20:18 error: unresolved import `std::io::File`. There is no `File` in `std::io`
/Users/coreyf/Development/rust/rust/src/grammar/verify.rs:20 use std::io::File;
                                                                 ^~~~~~~~~~~~~
error: aborting due to previous error
make: *** [/Users/coreyf/Development/rust/rust//grammar/verify] Error 101

I'm surprised this is not causing issues because the Makefile claims that this target should get run by Bors everytime upon check-in

@steveklabnik
Copy link
Member

I am pretty sure that it doesn't actually work, and that all of this has just rotted.

@pnkfelix
Copy link
Member

cc me

(i think there is something going wrong where only some host environments will actually try to run the steps associated with this target, and our buildbots are not in that set. But I do know that I hit this problem myself when I try to emulate the buildbots and run make check-all.)

steveklabnik added a commit to steveklabnik/rust that referenced this issue May 7, 2015
…, r=alexcrichton

I know this is the most trivial thing since it's *just* the model lexer, not the real lexer, but [it is simpler to read](rust-lang#15883 (comment)) and it'd be great if it was up to date but [it's been rotting](rust-lang#22379) and this is a tiny bit of that.

Thanks!!!!!!
steveklabnik added a commit to steveklabnik/rust that referenced this issue May 7, 2015
…, r=alexcrichton

I know this is the most trivial thing since it's *just* the model lexer, not the real lexer, but [it is simpler to read](rust-lang#15883 (comment)) and it'd be great if it was up to date but [it's been rotting](rust-lang#22379) and this is a tiny bit of that.

Thanks!!!!!!
@steveklabnik
Copy link
Member

Triage: on my machine:

$ make check-build-lexer-verifier 
cfg: version 1.11.0-dev (763f9234b 2016-06-06)
<snip>
cfg: including test rules
$ echo $?
0

So, it seems like this has been fixed, at least on my machine. Though as I said above, it's not like this is seeing any active development, and I don't even know if it's truly working, just that it returns zero. I'm not sure if this should be left open or closed, frankly...

@alexcrichton
Copy link
Member

Make's now gone, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants