#ast should only generate calls to the qquote module #2260

brson · 2012-04-20T07:07:36Z

The #ast extension generates code that makes calls to internal rustc APIs. Most of those calls are to functions in the qquote module itself, but some are to the parser. This makes changing these parser functions difficult, since the stage0 compiler will continue generating calls to the old function. Code generated by #ast should use an obvious, qquote-specific API, and preferably shouldn't mention any types that exist outside of the qquote module.

For example, the types and functions used by #fmt-generated code all live in std::extfmt::rt.

The text was updated successfully, but these errors were encountered:

graydon · 2013-03-12T23:01:12Z

the replacement (quote.rs) code for this routes everything through syntax::ext::quote::rt. Closing.

Use FnAbi instead of function signature when generating code for function types. Properly check the `PassMode::Ignore`. For foreign functions, instead of ignoring the declaration type, cast the arguments and return value. For now, we also ignore the caller location, since we don't currently support tracking caller location. This change makes it easier for us to do so. We might want to wait for this issue to get fixed so we can easily add support using stable APIs: rust-lang/project-stable-mir#62 Resolves rust-lang#2260 Resolves rust-lang#2312 Resolves rust-lang#1365 Resolves rust-lang#1350

graydon closed this as completed Mar 12, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#ast should only generate calls to the qquote module #2260

#ast should only generate calls to the qquote module #2260

brson commented Apr 20, 2012

graydon commented Mar 12, 2013

#ast should only generate calls to the qquote module #2260

#ast should only generate calls to the qquote module #2260

Comments

brson commented Apr 20, 2012

graydon commented Mar 12, 2013