-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: generated trait impls for arrays are very noisy #23986
Labels
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
aturon
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Apr 2, 2015
Dupe of #21660 |
vi
added a commit
to vi/rust
that referenced
this issue
Jan 31, 2018
Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower.
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Feb 25, 2018
…umeGomez,QuietMisdreavus rustdoc: Foldable impl blocks Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
bors
added a commit
that referenced
this issue
Feb 28, 2018
…ietMisdreavus rustdoc: Foldable impl blocks Addresses #40363, #45720, #24483, #23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, looking at the docs for
Vec
, some important trait implementations are hard to find in between all thePartialEq
implementations for each size of fixed-size arrays: http://static.rust-lang.org/doc/master/std/vec/struct.Vec.htmlHopefully these impls will eventually become generic, but in the meantime we should consider some way of hiding or collapsing them in the docs.
The text was updated successfully, but these errors were encountered: