Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Alter mem::forget to be safe (RFC 1066) #25186

Closed
aturon opened this issue May 7, 2015 · 1 comment · Fixed by #25187
Closed

Tracking issue for Alter mem::forget to be safe (RFC 1066) #25186

aturon opened this issue May 7, 2015 · 1 comment · Fixed by #25187
Assignees
@alexcrichton
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.

Comments

@aturon
Copy link
Member

aturon commented May 7, 2015

rust-lang/rfcs#1066
@aturon aturon added A-libs B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 7, 2015
@alexcrichton alexcrichton self-assigned this May 7, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 7, 2015
@alexcrichton
std: Mark mem::forget as a safe function
e8ea4b4 
This commit is an implementation of [RFC 1066][rfc] where the conclusion was
that leaking a value is a safe operation in Rust code, so updating the signature
of this function follows suit.

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1066-safe-mem-forget.md

Closes rust-lang#25186
@alexcrichton alexcrichton mentioned this issue May 7, 2015
Merged
@alexcrichton
Copy link
Member

Removing beta-nominated here as the PR is beta-nominated

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 7, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 7, 2015
@alexcrichton
std: Mark mem::forget as a safe function
a3aabdf 
This commit is an implementation of [RFC 1066][rfc] where the conclusion was
that leaking a value is a safe operation in Rust code, so updating the signature
of this function follows suit.

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1066-safe-mem-forget.md

Closes rust-lang#25186
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 8, 2015
@alexcrichton
std: Mark mem::forget as a safe function
dd59b1f 
This commit is an implementation of [RFC 1066][rfc] where the conclusion was
that leaking a value is a safe operation in Rust code, so updating the signature
of this function follows suit.

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1066-safe-mem-forget.md

Closes rust-lang#25186
bors added a commit that referenced this issue May 8, 2015
@bors
Auto merge of #25187 - alexcrichton:mem-forget-safe, r=brson
7132092 
This commit is an implementation of [RFC 1066][rfc] where the conclusion was
that leaking a value is a safe operation in Rust code, so updating the signature
of this function follows suit.

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1066-safe-mem-forget.md

Closes #25186
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 11, 2015
@alexcrichton
std: Mark mem::forget as a safe function
7b78086 
This commit is an implementation of [RFC 1066][rfc] where the conclusion was
that leaking a value is a safe operation in Rust code, so updating the signature
of this function follows suit.

[rfc]: https://github.com/rust-lang/rfcs/blob/master/text/1066-safe-mem-forget.md

Closes rust-lang#25186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std: Mark mem::forget as a safe function alexcrichton/rust
2 participants
@alexcrichton @aturon