Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dynamic_size_of call size_of in rust_shape #2894

Closed
catamorphism opened this issue Jul 13, 2012 · 1 comment
Closed

Make dynamic_size_of call size_of in rust_shape #2894

catamorphism opened this issue Jul 13, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone

Comments

@catamorphism
Copy link
Contributor

From a FIXME before the size_of class in rt/rust_shape.h: "Maybe ```dynamic_size_of() should call into this somehow?"

@catamorphism
Copy link
Contributor Author

Shape code is dead, long live shape code

RalfJung pushed a commit to RalfJung/rust that referenced this issue May 13, 2023
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Rewrite the reachability module to use Stable APIs wherever possible.
Note that in StableMIR the instance body is already monomorphized and
constants are already evaluated, which simplifies the code for most of
it, except to handle stubbing issue rust-lang#2589.

For the stubbing issue, we still use a mix of stable and internal APIs
to detect an invalid monomorphization.

Co-authored-by: Adrian Palacios <[email protected]>
Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

1 participant