Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for braced_empty_structs (RFC 218) #29720

Closed
aturon opened this issue Nov 9, 2015 · 7 comments
Closed

Tracking issue for braced_empty_structs (RFC 218) #29720

aturon opened this issue Nov 9, 2015 · 7 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@aturon
Copy link
Member

aturon commented Nov 9, 2015

Allows empty structs using braces, as per rust-lang/rfcs#218. This issue tracks stabilization.
@aturon aturon added T-lang Relevant to the language team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Nov 9, 2015
@petrochenkov
Copy link
Contributor

Need to land #29383 and fix #29548 before stabilizing

alex added a commit to alex/rust-asn1 that referenced this issue Nov 23, 2015
@alex
Added a special case for empty SEQUENCE until rust-lang/rust#29720 is…
c99cccf 
… landed
@petrochenkov
Copy link
Contributor

I'd like to have this stabilized in this cycle.
#29548 can actually be fixed in much cleaner way if the feature gate is removed, so I suggest to remove it sooner and not in the end of the cycle.

@petrochenkov
Copy link
Contributor

I can't ping @rust-lang/lang, so ping @aturon

@alexcrichton
Copy link
Member

cc @rust-lang/lang (yay github permissions?)

@alexcrichton
Copy link
Member

triage: I-nominated

@aturon aturon added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed I-nominated labels Jan 30, 2016
@aturon
Copy link
Member Author

aturon commented Jan 30, 2016

The lang team is moving this feature into final comment period. 🎱

@aturon
Copy link
Member Author

aturon commented Feb 26, 2016

The lang team has decided to stabilize this feature.

@aturon aturon removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 26, 2016
@alexcrichton alexcrichton mentioned this issue Feb 26, 2016
Merged
bors added a commit that referenced this issue Feb 29, 2016
@bors
Auto merge of #31928 - alexcrichton:stabilize-1.8, r=aturon
52cb8a9 
This commit is the result of the FCPs ending for the 1.8 release cycle for both
the libs and the lang suteams. The full list of changes are:

Stabilized

* `braced_empty_structs`
* `augmented_assignments`
* `str::encode_utf16` - renamed from `utf16_units`
* `str::EncodeUtf16` - renamed from `Utf16Units`
* `Ref::map`
* `RefMut::map`
* `ptr::drop_in_place`
* `time::Instant`
* `time::SystemTime`
* `{Instant,SystemTime}::now`
* `{Instant,SystemTime}::duration_since` - renamed from `duration_from_earlier`
* `{Instant,SystemTime}::elapsed`
* Various `Add`/`Sub` impls for `Time` and `SystemTime`
* `SystemTimeError`
* `SystemTimeError::duration`
* Various impls for `SystemTimeError`
* `UNIX_EPOCH`
* `ops::{Add,Sub,Mul,Div,Rem,BitAnd,BitOr,BitXor,Shl,Shr}Assign`

Deprecated

* Scoped TLS (the `scoped_thread_local!` macro)
* `Ref::filter_map`
* `RefMut::filter_map`
* `RwLockReadGuard::map`
* `RwLockWriteGuard::map`
* `Condvar::wait_timeout_with`

Closes #27714
Closes #27715
Closes #27746
Closes #27748
Closes #27908
Closes #29866
Closes #28235
Closes #29720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @aturon @petrochenkov @rust-highfive