Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing From<Vec<T>> for Cow<'a, [T]> impl #31354

Closed
talchas opened this issue Feb 2, 2016 · 1 comment
Closed

missing From<Vec<T>> for Cow<'a, [T]> impl #31354

talchas opened this issue Feb 2, 2016 · 1 comment

Comments

@talchas
Copy link

talchas commented Feb 2, 2016

Both Vec and &[T] are missing From impls for Cow, unlike String/&str and PathBuf/&Path. Coherence is not (afaict) an issue, since the impl would be in the same crate as Cow.

Is there some reason these don't exist (do they cause coherence issues in downstream crates or something)?
@alexcrichton
Copy link
Member

Whoa, I have no idea why these aren't implemented... Should be good to go ahead and add them! Want to send a PR?

@tbu- tbu- mentioned this issue Feb 3, 2016
Merged
tbu- added a commit to tbu-/rust that referenced this issue Feb 3, 2016
@tbu-
Add Cow::from for Vec and slices
f30f569 
Fixes rust-lang#31354.
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 5, 2016
@Manishearth
Rollup merge of rust-lang#31386 - tbu-:pr_cow_from_vec, r=alexcrichton
d566021 
Fixes rust-lang#31354.
bors added a commit that referenced this issue Feb 5, 2016
@bors
Auto merge of #31386 - tbu-:pr_cow_from_vec, r=alexcrichton
2ad6dc2 
Fixes #31354.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @alexcrichton @talchas