Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustbuild: make a config.toml entry for codegen tests #36232

Closed
durka opened this issue Sep 2, 2016 · 2 comments
Closed

rustbuild: make a config.toml entry for codegen tests #36232

durka opened this issue Sep 2, 2016 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@durka
Copy link
Contributor

durka commented Sep 2, 2016 •
edited
Loading

If you configure for system LLVM and run bootstrap.py without first running ./configure --disable-codegen-tests, the sanity check panics:

thread 'main' panicked at 'filecheck executable "/root/rust/FileCheck" does not exist', src/bootstrap/sanity.rs:93

(where /root/rust is the directory part of the path to llvm-config given in config.toml)

Per @alexcrichton there should be an option in config.toml to disable the codegen tests.
@alexcrichton alexcrichton added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. labels Sep 3, 2016
@alexcrichton
Copy link
Member

Should be a pretty easy bug to tackle! What needs to happen here is:

@durka
Copy link
Contributor Author

durka commented Sep 3, 2016

I'll take it!

@durka durka mentioned this issue Sep 3, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 4, 2016
@Manishearth
Rollup merge of rust-lang#36234 - durka:disable-codegen-config, r=ale…
a139242 
…xcrichton

rustbuild: add config.toml option to disable codegen tests

Fixes rust-lang#36232.

I think it worked? Here's a build log where I tried to bootstrap, it crashed, then I added the setting to config.toml and it continued: https://gist.github.com/durka/cbf97cf04b8e065f1a2cfda4c1b6bf95

r? @alexcrichton
Manishearth added a commit to Manishearth/rust that referenced this issue Sep 4, 2016
@Manishearth
Rollup merge of rust-lang#36234 - durka:disable-codegen-config, r=ale…
55893f0 
…xcrichton

rustbuild: add config.toml option to disable codegen tests

Fixes rust-lang#36232.

I think it worked? Here's a build log where I tried to bootstrap, it crashed, then I added the setting to config.toml and it continued: https://gist.github.com/durka/cbf97cf04b8e065f1a2cfda4c1b6bf95

r? @alexcrichton
@isuruf isuruf mentioned this issue Jul 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@durka @alexcrichton