Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-edit 0.1.3 does not build and install with rustc 1.15.0-nightly (ebeee0e27 2016-12-04) #38444

Closed
brson opened this issue Dec 18, 2016 · 5 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@brson
Copy link
Contributor

brson commented Dec 18, 2016

rustc 1.15.0-nightly (ebeee0e27 2016-12-04)

cargo install cargo-edit

   Compiling curl-sys v0.1.35
   Compiling lazy_static v0.2.2
   Compiling winapi-build v0.1.1
   Compiling toml v0.1.30
   Compiling quick-error v1.1.0
   Compiling kernel32-sys v0.2.2
   Compiling nom v1.2.4
   Compiling semver v0.2.3
   Compiling libc v0.2.18
   Compiling thread-id v2.0.0
   Compiling thread_local v0.2.7
   Compiling log v0.3.6
   Compiling memchr v0.1.11
   Compiling aho-corasick v0.5.3
   Compiling regex v0.1.80
   Compiling docopt v0.6.86
   Compiling unicode-bidi v0.2.3
^P   Compiling idna v0.1.0
   Compiling url v1.2.4
   Compiling curl v0.2.19
   Compiling cargo-edit v0.1.3
error: unnecessary qualification
  --> /home/ec2-user/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/cargo-edit-0.1.3/src/manifest.rs:13:1
   |
13 | quick_error! {
   | ^
   |
note: lint level defined here
  --> /home/ec2-user/.cargo/registry/src/jackfan.us.kg-1ecc6299db9ec823/cargo-edit-0.1.3/src/lib.rs:4:176
   |
4  | #![deny(missing_docs, missing_debug_implementations, missing_copy_implementations, trivial_casts, trivial_numeric_casts, unsafe_code, unstable_features, unused_import_braces, unused_qualifications)]
   |                                                                                                                                                                                ^^^^^^^^^^^^^^^^^^^^^
   = note: this error originates in a macro outside of the current crate

error: aborting due to previous error

error: failed to compile `cargo-edit v0.1.3`, intermediate artifacts can be found at `/tmp/cargo-install.2veDEfppY1Ba`

Caused by:
  Could not compile `cargo-edit`.
@brson brson added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Dec 18, 2016
@brson
Copy link
Contributor Author

brson commented Dec 18, 2016

cc @killercup

@killercup
Copy link
Member

Interesting. I'm not sure which unused_qualifications is triggered in the macro code, and don't have the time to investigate this now. Do you think this is a bug in rustc or something that was actually just not caught before and is fixed now?

I can release a hotfix release without that lint in the meantime.

@arielb1
Copy link
Contributor

arielb1 commented Dec 22, 2016

1.15.0 is now beta

@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Dec 22, 2016
killercup added a commit to killercup/cargo-edit that referenced this issue Dec 27, 2016
homu added a commit to killercup/cargo-edit that referenced this issue Dec 27, 2016
Release/0.1.4

A bugfix release to update dependencies and avoid rust-lang/rust#38444
@killercup
Copy link
Member

Just published cargo-edit 0.1.4 without this lint (and a bunch of dependency updates).

@brson
Copy link
Contributor Author

brson commented Dec 29, 2016

Since this is just a change in lints, I don't think there's anything to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

3 participants