Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl FromIterator<Cow<str>> for String #41351

Closed
Eh2406 opened this issue Apr 17, 2017 · 2 comments
Closed

impl FromIterator<Cow<str>> for String #41351

Eh2406 opened this issue Apr 17, 2017 · 2 comments
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Eh2406
Copy link
Contributor

Eh2406 commented Apr 17, 2017

I was surprised that I could not collect my cows. Can we add the ability to herd cows into a string?
@codyps
Copy link
Contributor

codyps commented Apr 18, 2017

Note that impl FromIterator<Borrow<str>> is likely a more generic version of what you're after here.

@Eh2406 Eh2406 mentioned this issue Apr 21, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 29, 2017
@frewsxcv
Rollup merge of rust-lang#41449 - Eh2406:master, r=aturon
598dad9 
FromIterator and Extend Cow for String

This is a quick draft to start working on [rust-lang#41351](rust-lang#41351).
I don't think I got the stable attributes correct, but it is good enuf to start a conversation.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 30, 2017
@frewsxcv
Rollup merge of rust-lang#41449 - Eh2406:master, r=aturon
ae0ed76 
FromIterator and Extend Cow for String

This is a quick draft to start working on [rust-lang#41351](rust-lang#41351).
I don't think I got the stable attributes correct, but it is good enuf to start a conversation.
frewsxcv added a commit to frewsxcv/rust that referenced this issue Apr 30, 2017
@frewsxcv
Rollup merge of rust-lang#41449 - Eh2406:master, r=aturon
ab99c9b 
FromIterator and Extend Cow for String

This is a quick draft to start working on [rust-lang#41351](rust-lang#41351).
I don't think I got the stable attributes correct, but it is good enuf to start a conversation.
@frewsxcv frewsxcv added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 30, 2017
@frewsxcv
Copy link
Member

Done in #41449.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codyps @frewsxcv @Eh2406