Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.py doesn't treat a codegen backend (src/librustc_codegen_llvm) change as a rustc change. #48298

Closed
eddyb opened this issue Feb 17, 2018 · 0 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@eddyb
Copy link
Member

eddyb commented Feb 17, 2018

At the very least, the tests don't appear to be re-checked. It's possible libstd is also not rebuilt.

@pietroalbini pietroalbini added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. WG-infra-rustbuild labels Feb 20, 2018
@eddyb eddyb changed the title x.py doesn't treat a codegen backend (src/librustc_trans) change as a rustc change. x.py doesn't treat a codegen backend (src/librustc_codegen_llvm) change as a rustc change. Nov 4, 2018
cuviper added a commit to cuviper/rust that referenced this issue Jan 16, 2019
Use `clear_if_dirty` on std for backend changes, just as we do for
changes to rustc itself, so new codegen is correctly applied to all
later compiler stages.

Fixes rust-lang#48298.
bors added a commit that referenced this issue Jan 20, 2019
[rustbuild] Rebuild std after changes to codegen backends

Use `clear_if_dirty` on std for backend changes, just as we do for
changes to rustc itself, so new codegen is correctly applied to all
later compiler stages.

Fixes #48298.
VardhanThigle pushed a commit to jethrogb/rust that referenced this issue Jan 31, 2019
Use `clear_if_dirty` on std for backend changes, just as we do for
changes to rustc itself, so new codegen is correctly applied to all
later compiler stages.

Fixes rust-lang#48298.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants