Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding self parameter to trait causes code to segfault #4850

Closed
mcpherrinm opened this issue Feb 8, 2013 · 4 comments
Closed

Adding self parameter to trait causes code to segfault #4850

mcpherrinm opened this issue Feb 8, 2013 · 4 comments
Labels
A-codegen Area: Code generation A-trait-system Area: Trait system I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.

Comments

@mcpherrinm
Copy link
Contributor

The following snippet segfaults when run. Removing the "self" parameters to thingie makes it not segfault, but makes rustc tell me that form is deprecated.

pub trait TestTrait {
  fn thingie(self) -> ~[u8];
}

impl ~[u8]: TestTrait {
  fn thingie(self) -> ~[u8] {
    ~[0u8]
  }
}

fn main() {
  let n = ~[];
  n.thingie();
}
@ghost ghost assigned catamorphism Feb 20, 2013
@graydon
Copy link
Contributor

graydon commented Mar 20, 2013

reproduced on 2013-03-20, seems imporant-ish

@catamorphism
Copy link
Contributor

Doesn't fail if I change self to &self, so I think the problem has to do with self being by-move.

@thestinger
Copy link
Contributor

#4355 is possibly related

This was referenced Mar 25, 2013
Closed
Closed
@graydon graydon mentioned this issue May 8, 2013
Closed
@dotdash dotdash mentioned this issue Jun 2, 2013
Closed
dotdash added a commit to dotdash/rust that referenced this issue Jun 2, 2013
@dotdash
Fix passing self by value for types passed by value
b51f44e 
For types that are passed by value, we can't just cast the value to a
pointer, but have to use an alloca and copy the value there. This
handling is already present for all other arguments, but was missing
for "self".

Fixes rust-lang#6682, rust-lang#4850 and rust-lang#4878
bors added a commit that referenced this issue Jun 3, 2013
@bors
auto merge of #6903 : dotdash/rust/self_by_value, r=catamorphism
4f6285f 
For types that are passed by value, we can't just cast the value to a
pointer, but have to use an alloca and copy the value there. This
handling is already present for all other arguments, but was missing
for "self".

Fixes #6682 #4850 #4878
@luqmana luqmana mentioned this issue Jun 26, 2013
Closed
@dotdash
Copy link
Contributor

dotdash commented Jun 27, 2013

This is fixed on master

bors added a commit that referenced this issue Jun 28, 2013
@bors
auto merge of #7410 : luqmana/rust/bare-self, r=catamorphism
61dc776 
Finally sorted this out. Fixes #5321, #4439, and #4850.
@luqmana luqmana closed this as completed Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation A-trait-system Area: Trait system I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@graydon @mcpherrinm @dotdash @luqmana @catamorphism @thestinger