Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export linenoise symbols from librustrt #5038

Closed
brson opened this issue Feb 19, 2013 · 4 comments · Fixed by #9897
Closed

Don't export linenoise symbols from librustrt #5038

brson opened this issue Feb 19, 2013 · 4 comments · Fixed by #9897
Labels
A-linkage Area: linking into static, shared libraries and binaries

Comments

@brson
Copy link
Contributor

brson commented Feb 19, 2013

The linenoise exports from librustrt prevent rust crates from linking to their own copies of line noise.

https://mail.mozilla.org/pipermail/rust-dev/2013-February/003187.html

I'm not sure the right solution to this. Maybe linenoise should be statically, and privately, linked to std.

@davbo
Copy link
Contributor

davbo commented Feb 20, 2013

This wasn't a problem once I created a shared library and stuck it somewhere in my LD_LIBRARY_PATH. See my follow-up email: https://mail.mozilla.org/pipermail/rust-dev/2013-February/003199.html

Not sure if you want to close this since it's no longer a problem (for me), it's possibly debatable whether it's a good idea to be exporting linenoise from librustrt?

@emberian
Copy link
Member

emberian commented Jul 7, 2013

Same with libuv, still relevant

@thestinger
Copy link
Contributor

This is still relevant.

@catamorphism
Copy link
Contributor

Clearing milestone, but it's still relevant

bors added a commit that referenced this issue Oct 17, 2013
Closes #9818
Closes #9567
Closes #8924
Closes #8910
Closes #8392
Closes #7692
Closes #7499
Closes #7220
Closes #5038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linkage Area: linking into static, shared libraries and binaries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants