Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all mentions of nil to unit or () #53719

Closed
oli-obk opened this issue Aug 26, 2018 · 2 comments
Closed

Rename all mentions of nil to unit or () #53719

oli-obk opened this issue Aug 26, 2018 · 2 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Aug 26, 2018

Ancient Rust used the term nil to describe the empty tuple. The compiler still uses this in a few places (e.g. the mk_nil method). All of these mentions should be changed to the current terminology or just outright () in comments.
@oli-obk oli-obk added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Aug 26, 2018
@lovesegfault
Copy link
Contributor

I'd like to take this on if that's okay @oli-obk :)

@oli-obk
Copy link
Contributor Author

oli-obk commented Aug 26, 2018

It's all yours!

@kenta7777 kenta7777 mentioned this issue Sep 10, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Sep 14, 2018
@kennytm
Rollup merge of rust-lang#54095 - kenta7777:kenta7777#53719, r=davidtwco
9c0f946 
Rename all mentions of `nil` to `unit`

Fixes rust-lang#53719.

Renamed keywords nil to unit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @lovesegfault